Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apollo-cache-control: consider hintless root fields to be uncached #2210

Merged
merged 2 commits into from
Jan 25, 2019
Merged

apollo-cache-control: consider hintless root fields to be uncached #2210

merged 2 commits into from
Jan 25, 2019

Commits on Jan 24, 2019

  1. apollo-cache-control: consider hintless root fields to be uncached 

    This is consistent with the old engineproxy interpretation of cache hints. We
special-case scalar fields to inherit their parent field's hints for
simplicity (so you don't have to hint every scalar field in a hinted object),
but when the parent field is non-root that inherited hint gets defaultMaxAge
applied to it. When the parent field is the root, that inherited hint doesn't
get defaultMaxAge applied because we don't run willResolveField for the root
query.

Includes a CHANGELOG update for #2197.
    @glasser
    glasser committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    ce287da View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Merge branch 'master' into glasser/default-max-age-root-scalars

    @abernix
    abernix authored Jan 25, 2019
    Configuration menu
    Copy the full SHA
    85306d7 View commit details
    Browse the repository at this point in the history