Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strict check for node version for graphql-upload #2235

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

mrkurt
Copy link
Contributor

@mrkurt mrkurt commented Jan 28, 2019

I'm working on a apollo-server-flyio package to use in fly.io apps. The fly app environment is not node, it's much closer to the browser, which means no access to fs, which means graphql-upload blows up on require.

This PR makes the Node version check more strict — if there are no node process details it avoids requiring the graphql-upload package for non-node runtimes. This is useful for me, obviously, but should also improve the Cloud Flare worker build experience and help with any future Deno efforts.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@mrkurt: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abernix abernix added this to the Release 2.3.3 milestone Jan 29, 2019
@abernix abernix merged commit cd674aa into apollographql:master Jan 29, 2019
@abernix
Copy link
Member

abernix commented Jan 29, 2019

Thank you for this! I made a couple follow-up commits to correct the name of the method and its file (which were no longer intuitive after this change), but this was released in v2.3.3.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants