Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate apollo-graphql package to apollo-tooling repo #2316

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Feb 14, 2019

The purpose of this PR is to remove the apollo-graphql package from this repository, to be added to apollo-tooling instead.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I thought about not merging this until after apollographql/apollo-tooling#1018 landed but I believe it's actually safer to not keep this code around in apollo-server and risk two copies getting changed independently. Consider this a temporary apollo-graphql code-freeze! 😉

If this ends up sending someone looking for the apollo-graphql source I hope this PR helps them, but I'm otherwise sorry for the temporary inconvenience. The new home for apollo-graphql is in apollo-tooling.

Thanks for doing this, @trevor-scheer !

@@ -21,7 +21,7 @@ module.exports = {
// We don't want to match `apollo-server-env` and
// `apollo-engine-reporting-protobuf`, because these don't depend on
// compilation but need to be initialized from as parto of `prepare`.
'^(?!apollo-server-env|apollo-engine-reporting-protobuf)(apollo-(?:server|graphql|datasource|cache-control|tracing|engine)[^/]*|graphql-extensions)(?:/dist)?((?:/.*)|$)': '<rootDir>/../../packages/$1/src$2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job catching this subtlety!

@abernix abernix merged commit 4f24edc into master Feb 14, 2019
abernix added a commit that referenced this pull request Feb 14, 2019
@abernix abernix deleted the trevor/migrate-apollo-graphql branch February 19, 2019 14:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants