Fix apollo-server-express context
TypeScript definition
#2349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed an issue when updating
apollo-server-express
today - my context function started breaking.It looked something like this
It seem to come from #2330 which enforces the output of the ContextFunction to be the same as the first arg to the function, which I think is wrong.
This PR allows you the
ContextFunction
to have an incoming and an outgoing context and let's you return whatever value you want in yourapollo-server-express
context.TODO: