apollo-server-express: Use req.originalUrl inside ApolloServer #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalUrl as playground endpoint.
|
@miguepintor: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
abernix
approved these changes
Apr 5, 2019
| const outerApp = express(); | ||
| outerApp.use(samplePath, innerApp); | ||
|
|
||
| const httpRewiredServer = await new Promise<http.Server>(resolve => { |
There was a problem hiding this comment.
I'm not asking but if you're so compelled, a follow-up PR that DRYs up these tests would sure be very much welcomed.
|
Thanks for this PR! It's been published in |
|
Err, sorry, canned copy-paste for releases. This is only on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves a minor issue.
When the apollo server express app is part (or it is used) inside other express apps the endpoint used to mount the playground is in correct.
