Update tslint to version 4.1.1 🚀 #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
Re-land: Add lifecycle hooks: willUpdateManifest, onUnregisteredOperation, onForbiddenOperation [AP-585] [AP-522]
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
This resolves a number of runtime errors which surfaced in the test suite for this repository, appearing as: TypeError: Cannot read property 'method' of undefined This was overlooked or not addressed within #158 / #246. While not ideal, today, Apollo Server has a very real expectation of an HTTP request context. That will change in the future. While we can sometimes make by without it, that is no longer the case when Engine Reporting is enabled since it relies on the HTTP "method" property of the HTTP context when building the traces. Therefore, we'll need to make sure that we provide a fake HTTP context to `executeOperation` when testing with Engine enabled, to ensure that it doesn't fail. cc @jsegaran
trevor-scheer
pushed a commit
that referenced
this pull request
May 12, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 12, 2020
Re-land: Add lifecycle hooks: willUpdateManifest, onUnregisteredOperation, onForbiddenOperation [AP-585] [AP-522]
trevor-scheer
pushed a commit
that referenced
this pull request
May 12, 2020
This resolves a number of runtime errors which surfaced in the test suite for this repository, appearing as: TypeError: Cannot read property 'method' of undefined This was overlooked or not addressed within #158 / #246. While not ideal, today, Apollo Server has a very real expectation of an HTTP request context. That will change in the future. While we can sometimes make by without it, that is no longer the case when Engine Reporting is enabled since it relies on the HTTP "method" property of the HTTP context when building the traces. Therefore, we'll need to make sure that we provide a fake HTTP context to `executeOperation` when testing with Engine enabled, to ensure that it doesn't fail. cc @jsegaran
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
Re-land: Add lifecycle hooks: willUpdateManifest, onUnregisteredOperation, onForbiddenOperation [AP-585] [AP-522]
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
This resolves a number of runtime errors which surfaced in the test suite for this repository, appearing as: TypeError: Cannot read property 'method' of undefined This was overlooked or not addressed within #158 / #246. While not ideal, today, Apollo Server has a very real expectation of an HTTP request context. That will change in the future. While we can sometimes make by without it, that is no longer the case when Engine Reporting is enabled since it relies on the HTTP "method" property of the HTTP context when building the traces. Therefore, we'll need to make sure that we provide a fake HTTP context to `executeOperation` when testing with Engine enabled, to ensure that it doesn't fail. cc @jsegaran
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
This resolves a number of runtime errors which surfaced in the test suite for this repository, appearing as: TypeError: Cannot read property 'method' of undefined This was overlooked or not addressed within #158 / #246. While not ideal, today, Apollo Server has a very real expectation of an HTTP request context. That will change in the future. While we can sometimes make by without it, that is no longer the case when Engine Reporting is enabled since it relies on the HTTP "method" property of the HTTP context when building the traces. Therefore, we'll need to make sure that we provide a fake HTTP context to `executeOperation` when testing with Engine enabled, to ensure that it doesn't fail. cc @jsegaran
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
tslint just published its new version 4.1.1.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of tslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade