Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide hash of engine API key to plugins via GraphQLServiceContext #2685

Merged
merged 4 commits into from
May 22, 2019

Conversation

cheapsteak
Copy link
Member

This PR makes the hash of the Engine API key available to plugins via GraphQLServiceContext.engine.apiKeyHash

This will allow plugins to access a service's storage secret

Make hash of Engine API key available to plugins via GraphQLServiceContext.engine.apiKeyHash

This will allow plugins to access a service's storage key
@cheapsteak cheapsteak requested review from abernix and jbaxleyiii May 17, 2019 21:21
@abernix abernix merged commit b1ab243 into master May 22, 2019
@abernix abernix deleted the chang/provide-api-key-hash branch May 22, 2019 15:35
@abernix abernix added this to the Release 2.6.0 milestone May 24, 2019
@glasser
Copy link
Member

glasser commented Jun 14, 2019

It looks like this commit lost the ability to set engine: false to make it ignore an env var. @cheapsteak was this intentional?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants