engine-reporting: Handle errors within didResolveOperation life-cycle hook.
#2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-implements the triggering of `didEncounterErrors` during `willResolveOperation` errors which occur in the request pipeline, but in a more common spot and where it probably should have been getting called already anyway.
This aims to accomplish one of the bits which was included within #2659 via a technique that scopes the errors more precisely. While I do think we should be passing all errors, the fix in #2659 was specifically aimed at a particular error-case which surfaced and we should consider a more refined approach to capturing those errors in the right places in future API iterations.
abernix
deleted the
abernix/deliver-didResolveOperation-errors-to-willSendResponse
branch
abernix
added a commit
that referenced
this pull request
May 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the triggering of
didEncounterErrorsduringwillResolveOperationerrors which occur in the request pipeline, but in a more common code-path where it probably should have been getting called already anyway.This re-implements part of the #2659 functionality (which is currently not included on the 2.6.0 branch) in a different manner, with the additional piece — still not included in this PR — to be included in a follow-up commit.