Preserve docstrings in SDL of federated services. #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonKearl
commented
Jun 12, 2019
| @@ -332,30 +332,20 @@ function printDescription( | |||
| | GraphQLEnumValue | |||
| | GraphQLUnionType, | |||
| indentation: string = '', | |||
| firstInBlock: boolean = true, | |||
| _firstInBlock: boolean = true, | |||
There was a problem hiding this comment.
Seems like this isn't really needed? Lists with descriptions seem to work out fine, as you can see from the above tests.
There was a problem hiding this comment.
@JacksonKearl yeah let's remove this
jbaxleyiii
suggested changes
Jun 12, 2019
| @@ -332,30 +332,20 @@ function printDescription( | |||
| | GraphQLEnumValue | |||
| | GraphQLUnionType, | |||
| indentation: string = '', | |||
| firstInBlock: boolean = true, | |||
| _firstInBlock: boolean = true, | |||
There was a problem hiding this comment.
@JacksonKearl yeah let's remove this
added 2 commits
June 12, 2019 08:41
jbaxleyiii
approved these changes
Jun 12, 2019
|
@JacksonKearl Does this work for |
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…l/jackson/preserve-federation-descriptions Preserve docstrings in SDL of federated services. Apollo-Orig-Commit-AS: apollographql/apollo-server@f3dcbb3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2808.