Example for the rootValue field documentation was incorrect

[ianfabs]

Example code on the rootValue field was incorrect

The JavaScript example for the rootValue field was syntactically incorrect, the original example tried to return an object inside a closure (exactly how one would do so, if they were trying to return an object from an arrow function), like so:

const server = new ApolloServer({
  typeDefs,
  resolvers,
  rootValue: (documentAST) => ({
    const op = getOperationAST(documentNode)
    return op === 'mutation' ? mutationRoot : queryRoot;
  }),
});

when in-fact the intent - as apparent from the code inside the {} - was to have said code inside the body of the arrow function. The correct syntax would be as follows:

const server = new ApolloServer({
  typeDefs,
  resolvers,
  rootValue: (documentAST) => {
    const op = getOperationAST(documentNode)
    return op === 'mutation' ? mutationRoot : queryRoot;
  },
});

Removing the () around the {} solves the issue.

Thank you for considering my PR.

[apollo-cla]

@ianfabs: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[ianfabs]

Do not approve, this example has more problems. I will fix these when I have an opportunity. Thank you for your time and consideration

[abernix]

@ianfabs Regardless, thank you for attempting to improve it! We'll leave this open for a bit, but you're also welcome to close it and re-open a new one, as necessary. :)

[trevor-scheer]

@ianfabs this looks like a good change to me, even if there are some other fixes to make in the vicinity. If you'd like to make further improvements in the future, maybe we can land this now and accept said improvements in a future PR? I'll check back in a few days and merge this unless I hear from you. Thanks again for the contribution!

[ianfabs]

I would be okay with this being accepted now, in the near future I will have time to expand upon this example further. Thank you for your time 😊

[trevor-scheer]

No, thank you!