Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lerna release pipeline #334

Merged
merged 4 commits into from
Mar 30, 2017
Merged

Lerna release pipeline #334

merged 4 commits into from
Mar 30, 2017

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Mar 22, 2017

Looks like there was a release without lerna pipe, this causes confusion as boostraping takes npm versions and not local versions.
I've aligned everything again so lerna will work as expected.

from now on, please use npm run release to release new versions.

TODO - Not needed i assume?:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

will be taken out of #308

@DxCx DxCx changed the title chore(package): align versions with lerna again Lerna release pipeline Mar 22, 2017
@DxCx
Copy link
Contributor Author

DxCx commented Mar 26, 2017

@helfer / @stubailo ?

@DxCx
Copy link
Contributor Author

DxCx commented Mar 28, 2017

@helfer , #320 is blocked because of this, can you please merge this?, rebase 320 and merge it as well. then we need to release new npm package

@stubailo stubailo self-assigned this Mar 28, 2017
@helfer
Copy link
Contributor

helfer commented Mar 30, 2017

Thanks @DxCx and sorry for the delay. Merging now!

@helfer helfer merged commit 4c1e4f1 into apollographql:master Mar 30, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants