Edits to APQ edits #3729
Merged
Edits to APQ edits #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @abernix ! One question on top of the above: can you specify a TTL for the in-memory cache that doesn't have one by default? Or is the in-memory cache an entirely no-TTL zone? |
|
@StephenBarlow Specifying the |
abernix
reviewed
Jan 28, 2020
abernix
added a commit
that referenced
this pull request
Feb 6, 2020
* Adjust heading levels, prior to additional changes. This makes room in the hierarchy for the work I'm about to add. * Adjust indentation of code-fences to be within the appropriate bullets. Otherwise, it was difficult to see the actual bullet-points. * Lower configuration to below the fold, letting the default behavior shine. We don't really demand configuration for this feature, which is enabled by default. Still, we have a lot more configuration that needs to be noted, which can't be done without sacrificing some of the structure of this page by inflating it with various implementation details that should be documented, but aren't - YET! (Stand-by for next commit!) * Add details about Redis, Redis Sentinel and Redis Cluster. Since the `cache` options themselves are usable on other interfaces within Apollo Server, these interfaces likely deserve to be documented on another page eventually, but for now, this works okay and is better than them not being documented at all. * Add details about adjusting the cache time-to-live (TTL). Specifically, this documents the behavior that was introduced by the below-referenced PR. Ref: #3623 * Provide instructions for how to disable persisted queries, if desired. This wasn't mentioned before, but seems worth documenting! * Edits to APQ edits (#3729) * Edits to APQ doc improvements * Update docs/source/performance/apq.md * Update docs/source/performance/apq.md Co-authored-by: Jesse Rosenberger <git@jro.cc> Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's edits all the way down