-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apollo-server-lambda] Add support for isBase64Encoded
#4311
Conversation
@styfle: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I had to sort out the Netlify build thing — which turns out to be actually affecting the entire repository, not just this PR. As you noted, I added a CHANGELOG.md
entry, but now I think this is good to go. Thanks! 😄
@abernix Great, thanks! What's the best way to get notified when this is released? I subscribed to GitHub Releases on this repo but it doesn't look like they are used, only tags. |
@styfle I put it on the milestone (2.16.0) where I believe it'll land. I try to drop messages on PRs within a release when the release ships, based on that milestone's contents — It's a manual ergonomic, but not usually too hard for me to remember. 😉 It probably won't be this week — since it'd be great to get a few more things into this release — but I'm trying to get some triaging and releasing done before Tuesday! |
@abernix Makes sense! I only see one item in the 2.16.0 Milestone so that should easy enough 😉 Looking forward to this release, thanks 👍 |
📣 Published in |
### Changes - Add new Runtime: `@vercel/redwood` - Update `run.js` script to sort packages properly ### Related - Related to #4539 - Related to #4535 - Depends on apollographql/apollo-server#4311
Can anyone see #4430? |
This PR adds support for Lambda Proxy when
isBase64Encoded: true
.The body must be decoded from base64 before parsing JSON.
https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html