Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brian/version 4 defer stream #6376

Closed

Conversation

brainkim
Copy link

@brainkim brainkim commented May 3, 2022

First, 🌠 thank you 🌠 for taking the time to consider a contribution to Apollo!

Here are some important details to follow:

  • ⏰ Your time is important
    To save your precious time, if the contribution you are making will take more
    than an hour, please make sure it has been discussed in an issue first.
    This is especially true for feature requests!

OK. Fine. This has been discussed in an issue.

  • πŸ’‘ Features
    Feature requests can be created and discussed within a GitHub Issue. Be
    sure to search for existing feature requests (and related issues!) prior to
    opening a new request. If an existing issue covers the need, please upvote
    that issue by using the πŸ‘ emote, rather than opening a new issue.

I’m trying to get work done here.

  • πŸ”Œ Integrations
    Apollo Server has many web-framework integrations including Express, Koa,
    Hapi and more. When adding a new feature, or fixing a bug, please take a
    peak and see if other integrations are also affected. In most cases, the
    fix can be applied to the other frameworks as well. Please note that,
    since new web-frameworks have a high maintenance cost, pull-requests for
    new web-frameworks should be discussed with a project maintainer first.

Okay.

  • πŸ•· Bug fixes
    These can be created and discussed in this repository. When fixing a bug,
    please try to add a test which verifies the fix. If you cannot, you should
    still submit the PR but we may still ask you (and help you!) to create a test.

This is not a bug fix.

Okay, fine. I skimmed it.

  • ✏️ Explain your pull request
    Describe the big picture of your changes here to communicate to what your
    pull request is meant to accomplish. Provide πŸ”— links πŸ”— to associated issues!

TODO: FINE.

We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment.

Please do not ask me to be positive. I am working πŸ˜›

Brian Kim added 2 commits May 3, 2022 15:22
Do the thing Glasser did in 7e41e67, except for the defer/stream branch.
I am ignoring the TypeScript errors. Forgive me, they were so convoluted, and in
tests.
@brainkim brainkim marked this pull request as draft May 3, 2022 23:42
@brainkim
Copy link
Author

brainkim commented May 4, 2022

Place for notes. DO NOT READ:

These are the test files which are run.

~/Work/apollo-server % npm run test 2>&1 | grep 'PASS' | pbcopy
~/Work/apollo-server % pbpaste | cut -d' ' -f2- | rev | cut -d' ' -f2- | cut -d' ' -f2- | rev
packages/server/src/__tests__/plugin/cacheControl/cacheControlDirective.test.ts
packages/server/src/__tests__/ApolloServer.test.ts
packages/server/src/__tests__/runQuery.test.ts
packages/server/src/__tests__/plugin/usageReporting/plugin.test.ts
packages/server/src/__tests__/express/expressSpecific.test.ts
packages/server/src/__tests__/plugin/usageReporting/stats.test.ts
packages/server/src/__tests__/documentStore.test.ts
packages/server/src/__tests__/plugin/cacheControl/dynamicCacheControl.test.ts
packages/server/src/__tests__/errors.test.ts
packages/server/src/__tests__/plugin/schemaReporting/schemaReporter.test.ts
packages/server/src/__tests__/ApolloError.test.ts
packages/server/src/__tests__/plugin/usageReporting/referencedFields.test.ts
packages/server/src/__tests__/logger.test.ts
packages/server/src/__tests__/plugin/cacheControl/cacheControlPlugin.test.ts
packages/server/src/__tests__/plugin/usageReporting/durationHistogram.test.ts
packages/server/src/__tests__/plugin/usageReporting/defaultUsageReportingSignature.test.ts
packages/server/src/__tests__/plugin/usageReporting/traceDetails.test.ts
packages/server/src/__tests__/plugin/schemaReporting/computeCoreSchemaHash.test.ts
packages/server/src/__tests__/cachePolicy.test.ts
packages/server/src/__tests__/plugin/usageReporting/operationDerivedDataCache.test.ts
packages/server/src/__tests__/plugin/schemaReporting/index.test.ts
packages/server/src/__tests__/plugin/drainHttpServer/stoppable.test.ts
packages/server/src/__tests__/rollupCommonJs.test.ts
packages/server/src/__tests__/express/integration.test.ts

Interesting links:
graphql/graphql-js#2839
graphql/graphql-js@cb48781

ATASTROPHIC THINGS WILL HAPPEN
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants