Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.prototype.includes is not a function in node versions <= 5 #72

Closed
jtschulz opened this issue May 30, 2017 · 1 comment
Closed

Comments

@jtschulz
Copy link
Contributor

In node V5, the Array.prototype.includes is hidden behind the harmony flag and not supported in earlier versions. In node 5.4.1, using the literal env throws:

TypeError: (0 , _lodash.keys)(...).map(...).includes is not a function

The entry point to the tests have the line:

require('babel-polyfill');

According to the node docs:

This will emulate a full ES2015+ environment and is intended to be used in an application rather than a library/tool.

Using transform-runtime is recommended for library code, which will not include instance methods and built-ins and pollute the global scope.

Per a slack conversation with @stubailo , I will be furnishing a pull request to solve this.

@jnwng
Copy link
Contributor

jnwng commented May 31, 2017

closed by #73

@jnwng jnwng closed this as completed May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants