Remove use of Array.prototype.includes to support older runtimes #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschulz
force-pushed
the
fix-literal-env-for-node-5
branch
from
523c087 to
b6fbe6c
Compare
|
(BTW - you can use |
stubailo
reviewed
May 30, 2017
CHANGELOG.md
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ### vNEXT | |||
|
|
|||
| ### v0.8.3 | |||
There was a problem hiding this comment.
For future PRs, please don't set the version number here and in package.json - sometimes we publish several things in one version
stubailo
reviewed
May 30, 2017
test/index.js
Outdated
| @@ -1,7 +1,9 @@ | |||
| // This file cannot be written with ECMAScript 2015 because it has to load | |||
| // the Babel require hook to enable ECMAScript 2015 features! | |||
| require('babel-core/register'); | |||
| require('babel-polyfill'); | |||
| require("babel-core").transform("code", { | |||
| plugins: ["transform-runtime"] | |||
There was a problem hiding this comment.
What does this change do?
There was a problem hiding this comment.
Oh never mind just read the description :]
There was a problem hiding this comment.
If there's something I can do to clarify the intention of this in the code, I'm super happy to add it.
Also removes `babel-polyfill` in favor of `transform-runtime` to surface these runtime-specific issues in testing.
jtschulz
force-pushed
the
fix-literal-env-for-node-5
branch
from
b6fbe6c to
97de688
Compare
|
@stubailo Thanks for the feedback 💇♂️ |
|
LGTM, @jnwng I think it's up to you to merge! |
|
thank you @PepperTeasdale! |
jtschulz
pushed a commit
to jtschulz/eslint-plugin-graphql
that referenced
this pull request
Jul 12, 2017
…llographql#73) Also removes `babel-polyfill` in favor of `transform-runtime` to surface these runtime-specific issues in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes
babel-polyfillin favor oftransform-runtimeto surface these runtime-specific issues in testing.@stubailo 👀 please
TODO:
;)