feat: federation 2.5 support #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for Federation specification v2.5. Changes: * new `@authenticated` directive ```graphql directive @authenticated on ENUM | FIELD_DEFINITION | INTERFACE | OBJECT | SCALAR ``` * new `@requiresScopes` directive ```graphql directive @requiresScopes(scopes: [[Scope!]!]!) on ENUM | FIELD_DEFINITION | INTERFACE | OBJECT | SCALAR scalar Scope ```
dariuszkuc
force-pushed
the
compatibility
branch
from
e71e47b to
3ad69af
Compare
dariuszkuc
changed the title
dariuszkuc
added
the
change: minor
Comment on lines
+1
to
+13
| extend schema @link(url: "https://specs.apollo.dev/federation/v2.5", import: ["@key"]) | ||
|
|
||
| directive @authenticated(role: [String!]!) on FIELD_DEFINITION | ||
|
|
||
| type Product @key(fields: "id") { | ||
| id: ID! | ||
| name: String! | ||
| supplier: String @authenticated(role: ["manager"]) | ||
| } | ||
|
|
||
| type Query { | ||
| product(id: ID!): Product | ||
| } |
There was a problem hiding this comment.
I'm sure it's less of a concern for requiresScopes but might be nice to have a similar test for completeness.
| | OBJECT | ||
| | SCALAR | ||
|
|
||
| scalar Scope |
There was a problem hiding this comment.
Pretty sure this needs to be federation__Scope everywhere it's defined and referenced by @requiresScopes. I would expect a composition error / incompatible definition for this.
Invalid definition for directive "@requiresScopes": argument "scopes" should have type "[[federation__Scope!]!]!" but found type "[[Scope!]!]!"
There was a problem hiding this comment.
federation__ namespace prefix should only be required if given directive/type is not explicitly imported (see the diff between the custom authenticated directive with no imports and default authorization with imports
trevor-scheer
approved these changes
Sep 6, 2023
dariuszkuc
added a commit
that referenced
this pull request
Oct 10, 2024
Adds support for [Federation specification v2.5](https://www.apollographql.com/docs/federation/federation-versions#v25). Changes: * new `@authenticated` directive ```graphql directive @authenticated on ENUM | FIELD_DEFINITION | INTERFACE | OBJECT | SCALAR ``` * new `@requiresScopes` directive ```graphql directive @requiresScopes(scopes: [[Scope!]!]!) on ENUM | FIELD_DEFINITION | INTERFACE | OBJECT | SCALAR scalar Scope ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Federation specification v2.5.
Changes:
@authenticateddirective@requiresScopesdirective