fix: default to not generate ftv1 traces #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Federation tracing should only be enabled if the Router/Gateway sends the proper ftv1 header and value. We want to default to false so we are not wasting CPU cycles tracking resolvers and building the extensions if it not going to be used https://www.apollographql.com/docs/federation/metrics/ Supersedes: #368
Closed
Apollo Federation Subgraph Compatibility Results
Learn more: |
dariuszkuc
added a commit
that referenced
this pull request
Oct 10, 2024
Federation tracing should only be enabled if the Router/Gateway sends the proper `ftv1` header and value. Currently trace data is generated even if the header is not specified which leads to unnecessary computations of data that will ultimately be discarded by the Router/Gateway.... If header is not specified, we should default to `false` to avoid those unnecessary computations. See: https://www.apollographql.com/docs/federation/metrics/ Supersedes: #368
martinbonnin
added a commit
that referenced
this pull request
Oct 28, 2024
I _think_ this is the new default (cf #370)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Federation tracing should only be enabled if the Router/Gateway sends the proper
ftv1header and value. Currently trace data is generated even if the header is not specified which leads to unnecessary computations of data that will ultimately be discarded by the Router/Gateway.... If header is not specified, we should default tofalseto avoid those unnecessary computations.See: https://www.apollographql.com/docs/federation/metrics/
Supersedes: #368