feat: add flag to CacheControlInstrumentation to optionally allow max-age of zero #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trophied
force-pushed
the
update-cache-control-zero-age-behavior
branch
from
74eca93
to
c087a47
Compare
dariuszkuc
approved these changes
May 15, 2024
|
Linter failed -> can you run |
Sure thing, I must have missed re-running after changing some stuff out 👍 |
trophied
force-pushed
the
update-cache-control-zero-age-behavior
branch
from
c087a47
to
cf1b1ff
Compare
dariuszkuc
requested changes
May 15, 2024
.../main/java/com/apollographql/federation/graphqljava/caching/CacheControlInstrumentation.java
Outdated
Show resolved
Hide resolved
…-age=0 This change updates the CacheControlInsturmentation class to include an optional flag for allowZeroMaxAge in order to provide a minimally invasive way to for consumers to configure their cache control to allow for a max-age of 0.
trophied
force-pushed
the
update-cache-control-zero-age-behavior
branch
from
cf1b1ff
to
139c3b2
Compare
dariuszkuc
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an optional flag to
CacheControlInstrumentation,allowZeroMaxAge, to allow consumers to configure the behavior such that resolved header can validly resolve a header value ofmax-age=0.