-
Notifications
You must be signed in to change notification settings - Fork 251
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix fetch group processing handling of dependencies (#2622)
The code that process `FetchGroup` in dependency order has a bug that, for some kind of dependencies, can finish with some group not handled, even though they could and should have been. In practice, this shows itself by failing the post-processing assertion that double-check that no groups are left unhandled.
- Loading branch information
Sylvain Lebresne
authored
Jun 14, 2023
1 parent
7f1ef73
commit 1293034
Showing
3 changed files
with
281 additions
and
68 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@apollo/query-planner": patch | ||
--- | ||
|
||
Fix bug in the handling of dependencies of subgraph fetches. This bug was manifesting itself as an assertion error | ||
thrown during query planning with a message of the form `Root groups X should have no remaining groups unhandled (...)`. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.