Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Use SECURITY core purpose for merged inaccessible spec #1715

Conversation

sachindshinde
Copy link
Contributor

In #1638 , as part of the ability to use @inaccessible in subgraphs, composition will add the inaccessible spec to the supergraph when it's used in a subgraph.

However, we currently don't specify a core purpose. We would like to use for: SECURITY in the core/link directive application for inaccessible. This PR makes this change via introducing defaultCorePurpose on FeatureDefinition.

@netlify
Copy link

netlify bot commented Apr 12, 2022

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 42eb105

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@sachindshinde sachindshinde merged commit c5a21bf into apollographql:main Apr 12, 2022
@benweatherman benweatherman mentioned this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants