Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetch group processing handling of dependencies #2622

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Fix fetch group processing handling of dependencies #2622

merged 3 commits into from
Jun 14, 2023

Commits on Jun 13, 2023

  1. Adds reproduction test

    @pcmanus
    pcmanus committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8df64b9 View commit details
    Browse the repository at this point in the history

  2. Fix handling of FetchGroup dependencies when processing them 

    The code that process `FetchGroup` in dependency order has a bug that,
for some kind of dependencies, can finish with some group not handled,
even though they could and should have been.

In practice, this shows itself by failing the post-processing assertion
that double-check that no groups are left unhandled.
    @pcmanus
    pcmanus committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ac2f5fa View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Address review feedback through slight refactor

    @pcmanus
    pcmanus committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    847e95a View commit details
    Browse the repository at this point in the history