feat(gateway): Update managed federation to fetch "cloud config"

.circleci/config.yml

@@ -71,6 +71,30 @@ jobs:
     steps:
       - common_test_steps
 
+  GraphQL Types:
+    description: "Assert generated GraphQL types are up to date"
+    executor: { name: oss/node, tag: '14' }
+    steps:
+      - oss/install_specific_npm_version
+      - checkout
+      # Install Rust
+      - rust/install:
+          version: stable
+
+      # Setup the Cargo env in CircleCI's BASH_ENV file.
+      #
+      # It's unfortunate that the rust/install Orb doesn't do this since this
+      # is a CircleCI-ism.  I've opened a PR in hopes of avoiding this,
+      # though it's possible that it's out of scope (or I'm doing smth wrong):
+      #
+      #   => https://github.com/CircleCI-Public/rust-orb/pull/3
+      #   => https://circleci.com/docs/2.0/env-vars/#setting-an-environment-variable-in-a-shell-command
+      #
+      - run: echo 'source $HOME/.cargo/env' >> $BASH_ENV
+      - oss/npm_clean_install_with_caching
+      - run:
+          command: npm run codegen:check
+
 # XXX We used to use this filter to only run a "Docs" job on docs branches.
 #     Now we use it to disable all jobs. It's unclear if there's a simpler way
 #     to do this!
@@ -103,18 +127,23 @@ workflows:
       - NodeJS 14:
           name: "JS: Node 14"
           <<: *common_non_publish_filters
+      - GraphQL Types:
+          name: "GraphQL Types (up to date)"
+          <<: *common_non_publish_filters
       - oss/lerna_tarballs:
           name: "JS: Package tarballs"
           <<: *common_non_publish_filters
           requires:
             - "JS: Node 12"
             - "JS: Node 14"
+            - "GraphQL Types (up to date)"
       - oss/dry_run:
           name: "JS: Dry-run"
           <<: *common_publish_filters
           requires:
             - "JS: Node 12"
             - "JS: Node 14"
+            - "GraphQL Types (up to date)"
       - oss/confirmation:
           name: "JS: Confirmation"
           type: approval

codegen.yml

@@ -0,0 +1,9 @@
+overwrite: true
+schema: "https://us-central1-mdg-services.cloudfunctions.net:443/cloudconfig-staging/"
+documents:
+  - gateway-js/src/loadCsdlFromStorage.ts
+generates:
+  gateway-js/src/__generated__/graphqlTypes.ts:
+    plugins:
+      - "typescript"
+      - "typescript-operations"

federation-integration-testsuite-js/src/fixtures/index.ts

@@ -4,6 +4,7 @@ import * as documents from './documents';
 import * as inventory from './inventory';
 import * as product from './product';
 import * as reviews from './reviews';
+import * as reviewsWithUpdate from './reviewsWithUpdate'
 
 export {
   accounts,
@@ -12,6 +13,7 @@ export {
   inventory,
   product,
   reviews,
+  reviewsWithUpdate
 };
 
 export const fixtures = [
@@ -23,6 +25,15 @@ export const fixtures = [
   reviews,
 ];
 
+export const fixturesWithUpdate = [
+  accounts,
+  books,
+  documents,
+  inventory,
+  product,
+  reviewsWithUpdate,
+];
+
 export const fixtureNames = [
   accounts.name,
   product.name,

federation-integration-testsuite-js/src/fixtures/reviewsWithUpdate.ts

@@ -0,0 +1,18 @@
+import gql from 'graphql-tag';
+
+import * as reviewsService from './reviews';
+
+export const name = reviewsService.name;
+export const url = reviewsService.url;
+
+// For simplicity the "new" resolver just already exists - we only need to
+// update the typeDefs with the newly added `review` field.
+export const resolvers = reviewsService.resolvers;
+
+// Add a new `review` field to the `Query` type
+export const typeDefs = gql`
+  extend type Query {
+    review(id: ID!): Review
+  }
+  ${reviewsService.typeDefs}
+`;

gateway-js/src/__tests__/execution-utils.ts

@@ -112,8 +112,8 @@ export function getFederatedTestingSchema(services: ServiceDefinitionModule[] =
   return { serviceMap, schema: compositionResult.schema, queryPlannerPointer };
 }
 
-export function getTestingCsdl() {
-  const compositionResult = composeAndValidate(fixtures);
+export function getTestingCsdl(services: typeof fixtures = fixtures) {
+  const compositionResult = composeAndValidate(services);
   if (!compositionHasErrors(compositionResult)) {
     return compositionResult.composedSdl;
   }

gateway-js/src/__tests__/gateway/executor.test.ts

@@ -118,10 +118,10 @@ describe('ApolloGateway executor', () => {
 
     expect(server.requestOptions.executor).toBe(gateway.executor);
 
-    expect(logger.error.mock.calls).toEqual([
-      ["Error checking for changes to service definitions: Tried to load services from remote endpoints but none provided"],
-      ["This data graph is missing a valid configuration. Tried to load services from remote endpoints but none provided"]
-    ]);
+    expect(logger.error).toHaveBeenCalledTimes(1);
+    expect(logger.error).toHaveBeenCalledWith(
+      "This data graph is missing a valid configuration. Tried to load services from remote endpoints but none provided"
+    );
 
     mockExit.mockRestore();
   });