Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message when loading schema on wrong state #460

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Fix error message when loading schema on wrong state #460

merged 3 commits into from
Feb 11, 2021

Conversation

kuskoman
Copy link
Contributor

@kuskoman kuskoman commented Feb 11, 2021

No description provided.

@apollo-cla
Copy link

@kuskoman: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much appreciated.

@glasser
Copy link
Member

glasser commented Feb 11, 2021

Whoops, thanks @kuskoman!

Is this just something you observed from reading the code, or are you actually triggering this error? If I missed a use case where load is called multiple times that would be good to know!

@glasser
Copy link
Member

glasser commented Feb 11, 2021

Ah, I see #461.

@glasser glasser merged commit eaacb47 into apollographql:main Feb 11, 2021
@kuskoman kuskoman deleted the fix-state-error-message branch February 11, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants