-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] chore: convert to TS #235
[WIP] chore: convert to TS #235
Conversation
Hmm, the tests seem like something else... This feels really weird since we're working with a |
In the tests two issues are still open V0.11: This test is not being executed in master atm so I did not migrate it to TypeScript The Also we need to find a way to test with these different versions but then with our new jest tests. Sorry for leaving this much open but it's quite hard to "choose" an infrastructure. I'll probably add test to the CI when the changes are approved |
tests for overall, i think translating this library to typescript is a useful effort. however. i would want to ensure that tests still pass — we don't want to drop any support unnecessarily, plus we'd expect the same behavior here. additionally, i don't feel comfortable merging the parts that are "unknown" in TypeScript-land, so it'd be valuable to have someone review this who might have the answers we need. in the pursuit of moving this forward, can we break this down into smaller pieces to get pieces of it through, first? perhaps splitting this into 1) infrastructural changes (e.g., the typescript toolchain) 2) typescript interfaces and 3) tests? that might allow us to have a more focused look at the individual parts of the library that are being ported. thoughts? |
@jnwng Steps:
Also when I look at the travis CI jobs (ex: https://travis-ci.org/apollographql/graphql-tag/jobs/476452576) I see that 0.11 fails, that's why I thought that. |
So as suggested by @benjamn I started on the conversion to TS, this has proven to be non-trivial, so I'm already putting it out there so anyone passing by can see and give their two cents about it
#234 (comment) --> ref to comment about conversion to TS