Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

remove result in favor of the key's returned by the query #31

Merged
merged 4 commits into from
Apr 26, 2016

Conversation

jbaxleyiii
Copy link
Contributor

Discussion in #30

cc @abhiaiyer91

@jbaxleyiii
Copy link
Contributor Author

I'm going to give this a day for people to chime in if they are interested / opposed to this change.

cc @stubailo @apollostack/community-contributors @johnthepink

@johnthepink
Copy link
Contributor

👍

@abhiaiyer91
Copy link
Contributor

I'm in :)

@abhiaiyer91
Copy link
Contributor

Thanks! I was going to do this but thanks for going for it!

@jbaxleyiii
Copy link
Contributor Author

@abhiaiyer91 I had some down time today 🎈

@stubailo stubailo self-assigned this Apr 25, 2016
@stubailo
Copy link
Contributor

I think this should be 0.2 to conform to NPM's semver handling!

@stubailo
Copy link
Contributor

I think we should add a warning in the case where the query returns a property that conflicts with other things we return like refetch, error, loading. It's easy to work around with an alias, but it would be great for people to find out about the problem early!

It would be a bit weird to have a root query called error, but who knows, especially as we add more metadata.

@abhiaiyer91
Copy link
Contributor

Yes we can also write some Eslint rules for Apollo Query data, and ship that tooling?

@stubailo
Copy link
Contributor

Eslint rules for Apollo Query data

What would they do? We can add it here maybe: https://github.com/apollostack/eslint-plugin-graphql

Since a plugin can ship multiple rules, we can add as many as we want to that plugin.

@jbaxleyiii
Copy link
Contributor Author

@stubailo I'll update this PR tonight 🎉

@jbaxleyiii
Copy link
Contributor Author

@stubailo this one should be good to go. I'm good with calling it discussed and merging if you are

@stubailo stubailo merged commit 6bc5027 into master Apr 26, 2016
@jbaxleyiii jbaxleyiii deleted the remove-result-key branch June 27, 2016 01:48
jbaxleyiii pushed a commit to apollographql/apollo-client that referenced this pull request Oct 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants