-
Notifications
You must be signed in to change notification settings - Fork 786
remove result in favor of the key's returned by the query #31
Conversation
I'm going to give this a day for people to chime in if they are interested / opposed to this change. cc @stubailo @apollostack/community-contributors @johnthepink |
👍 |
I'm in :) |
Thanks! I was going to do this but thanks for going for it! |
@abhiaiyer91 I had some down time today 🎈 |
I think this should be |
I think we should add a warning in the case where the query returns a property that conflicts with other things we return like It would be a bit weird to have a root query called |
Yes we can also write some Eslint rules for Apollo Query data, and ship that tooling? |
What would they do? We can add it here maybe: https://github.com/apollostack/eslint-plugin-graphql Since a plugin can ship multiple rules, we can add as many as we want to that plugin. |
@stubailo I'll update this PR tonight 🎉 |
… key, also correct semver version bump
@stubailo this one should be good to go. I'm good with calling it discussed and merging if you are |
Corresponding PR (apollographql/react-apollo#31) and issue (apollographql/react-apollo#30)
Discussion in #30
cc @abhiaiyer91