-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
response_body is not valid under telemetry spans for custom attribute #4830
Comments
it looks like this is happening because |
Are you saying |
Yep, adding here that under supergraph attributes in the YAML config, we only allow these response attributes (as seen from the generated
Yet our docs indicate that we have support for If we add support for
|
Hmm, yes |
The main issue with implementing this is that the response when we get to the supergraph stage is a stream. To support this we will need to extend the Selector trait to add somethign along the lines of |
This attribute is not yet implemented, we are tracking the work to do that in apollographql#4830 However until we actually implement it we should remove from the docs
Removing from the docs here to reduce confusion until it is actually implemented: #4905 |
This attribute is not yet implemented, we are tracking the work to do that in #4830 However until we actually implement it we should remove from the docs
@bnjjj Is this fixed by your latest PR? |
Yes it's part of this PR but it will be |
Yes! |
https://www.apollographql.com/docs/router/configuration/telemetry/instrumentation/selectors/#supergraph
It says supergraph has selector of
response_body
, but the router config schema does not contain it. Add a custom attribute under supergraph would fail.Expected behavior
Expect
response_body
selector to be valid under either supergraph or router.Output
The text was updated successfully, but these errors were encountered: