Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded option #257

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Remove unneeded option #257

merged 2 commits into from
Dec 10, 2021

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Dec 9, 2021

No description provided.

@cecton cecton marked this pull request as ready for review December 9, 2021 14:16
@cecton cecton mentioned this pull request Dec 9, 2021
Merged
o0Ignition0o
o0Ignition0o approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really sure why the custom deserializer was here, IIRC there used to be some serialization / deserialization misshaps in the router-bridge or something.

LGTM if tested

@cecton
Copy link
Contributor Author

cecton commented Dec 10, 2021

not really sure why the custom deserializer was here, IIRC there used to be some serialization / deserialization misshaps in the router-bridge or something.

oh actually I broke a test when I removed the option. Apparently providing null should be considered the same as not providing something at all. Unfortunately serde_json thinks it's a different type if I remove the option. That is why I had to add the deserialize_null_default which takes cares of this particular case.

@cecton cecton mentioned this pull request Dec 10, 2021
Merged
@cecton cecton merged commit fc1d84c into main Dec 10, 2021
@cecton cecton deleted the cecton-remove-unneeded-option branch December 10, 2021 13:51
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this pull request Oct 16, 2023
@github-actions @apollo-bot2 @trevor-scheer
Automated PR for router-bridge release 2.3.3 (apollographql#257)
f7362f4 
Automated changes by
[create-pull-request](https://github.com/peter-evans/create-pull-request)
GitHub action

Co-authored-by: apollo-bot2 <apollo-bot2@users.noreply.github.com>
Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garypen garypen garypen approved these changes

@Geal Geal Geal approved these changes

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

@BrynCooke BrynCooke Awaiting requested review from BrynCooke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cecton @garypen @Geal @o0Ignition0o