add the missing skip_all on instrument attributes #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geal
commented
Dec 21, 2021
o0Ignition0o
approved these changes
Jan 4, 2022
cecton
approved these changes
Jan 5, 2022
Geal
commented
Jan 5, 2022
| @@ -4210,6 +4210,7 @@ <h4>Used by:</h4> | |||
| <li><a href=" https://github.com/bluss/indexmap ">indexmap</a></li> | |||
| <li><a href=" https://github.com/rust-itertools/itertools ">itertools</a></li> | |||
| <li><a href=" https://github.com/dtolnay/itoa ">itoa</a></li> | |||
| <li><a href=" https://github.com/dtolnay/itoa ">itoa</a></li> | |||
There was a problem hiding this comment.
I keep having to add it again, while the licenses file from main is already fine 🤔
tinnou
pushed a commit
to Netflix-Skunkworks/router
that referenced
this pull request
Oct 16, 2023
lennyburdette
pushed a commit
that referenced
this pull request
Dec 20, 2023
qol: move a couple of printlns to tracing debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the telemetry ADR specifies that we set skip_all on
#[tracing::instrument]to avoid serializing arguments on every call