Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requires selection in arrays #3975

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Fix requires selection in arrays #3975

merged 8 commits into from
Oct 9, 2023

Commits on Oct 5, 2023

  1. add a test demonstrating selection bugs 

    here we have a selection with 2 fragments
    @Geal
    Geal committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7d0cd14 View commit details
    Browse the repository at this point in the history

  2. add another test

    @Geal
    Geal committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    0a42ad3 View commit details
    Browse the repository at this point in the history

  3. test passes

    @Geal
    Geal committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d6e6462 View commit details
    Browse the repository at this point in the history

  4. complete the test

    @Geal
    Geal committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c9ea5d9 View commit details
    Browse the repository at this point in the history

  5. aggregate array elements even if some would be null

    @Geal
    Geal committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d6d4f2c View commit details
    Browse the repository at this point in the history

  6. lint

    @Geal
    Geal committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    7c1cf53 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. add a comment

    @Geal
    Geal committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    609c9bc View commit details
    Browse the repository at this point in the history

  2. changeset

    @Geal
    Geal committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e43eb7c View commit details
    Browse the repository at this point in the history