Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demand Control: Estimate cost for a query plan #4860

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Conversation

tninesling
Copy link
Contributor

@tninesling tninesling commented Mar 26, 2024

Estimates the cost of a query plan by aggregating the costs of operations in the individual fetch nodes. For multiple nodes, the total cost is the sum of the individual costs. For a conditional branch, the cost is the max of the two branches. All deferred nodes count toward the static cost as if they were not deferred.

ROUTER-174


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@router-perf
Copy link

router-perf bot commented Mar 26, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

@tninesling tninesling changed the base branch from tninesling/subgraph-schemas to tninesling/subgraph-schemas-2 March 27, 2024 20:11
@tninesling tninesling changed the base branch from tninesling/subgraph-schemas-2 to dev March 28, 2024 15:17
@tninesling tninesling changed the base branch from dev to tninesling/subgraph-schemas-2 March 28, 2024 15:28
@tninesling tninesling changed the base branch from tninesling/subgraph-schemas-2 to dev April 1, 2024 21:08
Copy link
Contributor

github-actions bot commented Apr 1, 2024

@tninesling, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@tninesling tninesling marked this pull request as ready for review April 2, 2024 17:05
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tninesling tninesling merged commit c9534a5 into dev Apr 4, 2024
14 checks passed
@tninesling tninesling deleted the tninesling/ROUTER-174 branch April 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants