-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demand Control: Estimate cost for a query plan #4860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI performance tests
|
tninesling
force-pushed
the
tninesling/ROUTER-174
branch
from
March 27, 2024 20:03
ffe70d3
to
d48bf01
Compare
tninesling
changed the base branch from
tninesling/subgraph-schemas
to
tninesling/subgraph-schemas-2
March 27, 2024 20:11
tninesling
force-pushed
the
tninesling/ROUTER-174
branch
from
March 28, 2024 15:17
e4c5efe
to
e606124
Compare
…tch node subgraph queries
…ese will come from PluginInit when the calculator is wired up to the plugin
tninesling
force-pushed
the
tninesling/ROUTER-174
branch
from
April 1, 2024 21:08
e606124
to
607bbcc
Compare
@tninesling, please consider creating a changeset entry in |
BrynCooke
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimates the cost of a query plan by aggregating the costs of operations in the individual fetch nodes. For multiple nodes, the total cost is the sum of the individual costs. For a conditional branch, the cost is the max of the two branches. All deferred nodes count toward the static cost as if they were not deferred.
ROUTER-174
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩