-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demand Control: Calculate actual cost for a response #4903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch node subgraph queries
…ese will come from PluginInit when the calculator is wired up to the plugin
…esling/ROUTER-175
CI performance tests
|
BrynCooke
reviewed
Apr 4, 2024
apollo-router/src/plugins/demand_control/schema_aware_response.rs
Outdated
Show resolved
Hide resolved
BrynCooke
approved these changes
Apr 4, 2024
@tninesling, please consider creating a changeset entry in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a third method to
CostCalculator
which scores the cost of a GraphQL response.The first stage of scoring a response is to zip it together with the request. The initial implementation does not use the request fields, but this will be required to support custom cost. In that case, we will need to check the corresponding request field definition to see if a custom cost needs to be applied to a particular response field. This information is stored in a counterpart to
serde_json::Value
, which is calledTypedValue
. ThisTypedValue
enum pairs each JSON value with the correspondingapollo_compiler::executable::Field
.Once the response values are paired with their corresponding fields, it is simple to traverse the JSON structure, taking query or schema directives into account.
Implements ROUTER-175
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩