-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sha256 support to rhai #4940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks good, just a few little NITS to sort out.
Co-authored-by: Gary Pennington <garypen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've lost a </Note>
somewhere. I think it should be under the base64 section.
This adds a new
sha256::digest
function to Rhai to enable hash values.Fixes #4939
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.