Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to process empty batches of requests #4969

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Apr 17, 2024

During testing we found an existing issue with batching support which causes the router to panic if an empty batch is submitted to the router.

This is only a problem if batching support is enabled.

We now explicitly check for empty batches and return a helpful error message if they are detected.

Ref: #4661

During testing we found an existing issue with batching support which
causes the router to panic if an empty batch is submitted to the router.

We now explicitly check for empty batches and return a helpful error
message if they are detected.
@garypen garypen requested a review from bnjjj April 17, 2024 07:59
@garypen garypen self-assigned this Apr 17, 2024
Copy link
Contributor

@garypen, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Apr 17, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

@garypen garypen enabled auto-merge (squash) April 17, 2024 11:00
@garypen garypen merged commit 18ef65b into dev Apr 17, 2024
13 of 14 checks passed
@garypen garypen deleted the garypen/ROUTER-223/empty-batch branch April 17, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants