Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add errors for response validation #5787

Open
wants to merge 32 commits into
base: dev
Choose a base branch
from
Open

add errors for response validation #5787

wants to merge 32 commits into from
+658 −16

Commits on Aug 7, 2024

  1. add errors for response validation 

    When formatting responses, the router is validating the data returned by
subgraphs and replacing it with null values as appropriate. MEssages
were put in the response extensions outlining the paths at which the
nulls were propagated up the response (due to non nullable types) but it
was not generating error messages for invalid values
    @Geal
    Geal committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b2bddc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge branch 'dev' into geal/response-validation-errors

    @Geal
    Geal authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    97a748d View commit details
    Browse the repository at this point in the history

  2. lint

    @Geal
    Geal committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6d62d38 View commit details
    Browse the repository at this point in the history

  3. lint

    @Geal
    Geal committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ffde309 View commit details
    Browse the repository at this point in the history

  4. align error messages with the gateway

    @Geal
    Geal committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6733583 View commit details
    Browse the repository at this point in the history

  5. error messages for invalid typename values

    @Geal
    Geal committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4747e4a View commit details
    Browse the repository at this point in the history

  6. lint

    @Geal
    Geal committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    24d46b9 View commit details
    Browse the repository at this point in the history

  7. update error messages

    @Geal
    Geal committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    36231f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'dev' into geal/response-validation-errors

    @Geal
    Geal committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    9cf401e View commit details
    Browse the repository at this point in the history

  2. Update apollo-router/src/json_ext.rs

    @Geal
    Geal authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    cecf18a View commit details
    Browse the repository at this point in the history

  3. revert __typename validation

    @Geal
    Geal committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    965cfd2 View commit details
    Browse the repository at this point in the history

  4. let null values go through

    @Geal
    Geal committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6f2fcaf View commit details
    Browse the repository at this point in the history

  5. fix

    @Geal
    Geal committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    99aef34 View commit details
    Browse the repository at this point in the history

  6. changeset

    @Geal
    Geal committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a59f15d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'dev' into geal/response-validation-errors

    @Geal
    Geal authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b201d28 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'dev' into geal/response-validation-errors

    @Geal
    Geal authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cb6eda8 View commit details
    Browse the repository at this point in the history

  2. add a test

    @Geal
    Geal committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d14767a View commit details
    Browse the repository at this point in the history

  3. fix enum validation error message

    @Geal
    Geal committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8fe0b68 View commit details
    Browse the repository at this point in the history

  4. check lists

    @Geal
    Geal committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9d17497 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'dev' into geal/response-validation-errors

    @Geal
    Geal committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d23b782 View commit details
    Browse the repository at this point in the history

  2. add an error code

    @Geal
    Geal committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6881f9b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Add a test for out-of-range values for Int

    @andrewmcgivery @goto-bus-stop
    andrewmcgivery authored and goto-bus-stop committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4006b2e View commit details
    Browse the repository at this point in the history

  2. Update test from #6143 to match the implementation from #5787

    @goto-bus-stop
    goto-bus-stop committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    468ae57 View commit details
    Browse the repository at this point in the history

  3. Fix parent type when result-coercing non-null types

    @goto-bus-stop
    goto-bus-stop committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e6020bb View commit details
    Browse the repository at this point in the history

  4. Fix result coercion for ID fields

    @goto-bus-stop
    goto-bus-stop committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    45c7e8a View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Add more tests for response value coercion/validation

    @goto-bus-stop
    goto-bus-stop committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7c7ba29 View commit details
    Browse the repository at this point in the history

  2. Move the response validation tests together

    @goto-bus-stop
    goto-bus-stop committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c34b7d1 View commit details
    Browse the repository at this point in the history

  3. Adjust test expectations to match current behaviour

    @goto-bus-stop
    goto-bus-stop committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    536d9f6 View commit details
    Browse the repository at this point in the history

  4. Correct parent type used for top-level fields

    @goto-bus-stop
    goto-bus-stop committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    877eb2c View commit details
    Browse the repository at this point in the history

  5. lint

    @goto-bus-stop
    goto-bus-stop committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4fa8353 View commit details
    Browse the repository at this point in the history

  6. Fix snapshot

    @goto-bus-stop
    goto-bus-stop committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e206b6d View commit details
    Browse the repository at this point in the history

  7. Revert ID validation fix--moving to separate PR

    @goto-bus-stop
    goto-bus-stop committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f0f7300 View commit details
    Browse the repository at this point in the history