fix(demand_control): use correct parent type in fragment definitions #6162
+142
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors like: ``` Attempted to look up a field on type MyInterface, but the field does not exist ``` Fragment definitions have a type condition, and all selections inside the fragment are executed against that type condition. Previously, the demand control cost calculator executed them against the parent type *where the fragment is used*, which is often different.
✅ Docs Preview ReadyNo new or changed pages found. |
|
@goto-bus-stop, please consider creating a changeset entry in |
goto-bus-stop
commented
Oct 16, 2024
| @@ -0,0 +1,102 @@ | |||
| schema | |||
There was a problem hiding this comment.
This is just the existing basic_schema.graphql run through rover compose to get a supergraph with a single subgraph.
|
CI performance tests
|
goto-bus-stop
commented
Oct 16, 2024
| } | ||
| Selection::InlineFragment(i) => self.score_inline_fragment( | ||
| ctx, | ||
| i, | ||
| i.type_condition.as_ref().unwrap_or(parent_type), | ||
| parent_type, |
There was a problem hiding this comment.
Moved this into score_inline_fragment, I think that makes more sense. It's less brittle if we add more places that call score_inline_fragment in the future, as every call site doesn't need to account for the type condition.
bnjjj
approved these changes
Oct 16, 2024
|
oops, i had enabled auto-merge. I'll follow up with a changeset |
goto-bus-stop
added a commit
that referenced
this pull request
Oct 16, 2024
abernix
pushed a commit
that referenced
this pull request
Oct 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #6013.
Fixes errors like:
Fragment definitions have a type condition, and all selections inside
the fragment are executed against that type condition. Previously, the
demand control cost calculator executed them against the parent type
where the fragment is used, which is often different.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩