Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: implement supergraph watcher #2133

Draft
wants to merge 24 commits into
base: composition-integration
Choose a base branch
from

Commits on Sep 10, 2024

  1. ROVER-135 Make paths in supergraph.yaml resolve relative to the locat…

    …ion of the file, not the current working directory of Rover (#2119)
    
    As per the title, to support integration with the Language Server we
    need to remove a 'quirk' of Rover whereby if you specify a file in the
    supergraph.yaml with a relative path, that path is resolved relative to
    the location that rover is running in at the time. This doesn't work in
    that context so instead we are changing it to resolve relative to the
    location of the supergraph.yaml file itself.
    
    I've added a unit test for this and run my own tests and it all seems to
    work ok.
    
    In addition I've fixed a test that has been broken for a long time, a
    more detailed write up on this test will follow
    
    Successful smoke test run:
    https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
    jonathanrainer authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1ed1a27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7eb8c50 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    f1671af View commit details
    Browse the repository at this point in the history
  2. moving dev_2 over to composition-integration (#2130)

    Co-authored-by: Brian George <brian@apollographql.com>
    aaronArinder and dotdat authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bdb8186 View commit details
    Browse the repository at this point in the history
  3. wip(composition): adding composition events, move types around, TODO'…

    …d impl of `SubtaskHandleStream` for `Composition` (#2131)
    
    Co-authored-by: Brian George <brian@apollographql.com>
    aaronArinder and dotdat authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7586992 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. dev: add watcher mod

    loshz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    34dacc6 View commit details
    Browse the repository at this point in the history
  2. add subgraph watcher kinds

    loshz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4ec253c View commit details
    Browse the repository at this point in the history
  3. mod use correct file

    loshz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5c755ef View commit details
    Browse the repository at this point in the history
  4. dev leader deprecation (#2132)

    ## Description
    
    Initial PR the remove leader/follower related code so we can build upon
    implementing new `rover dev` command while keeping changes atomic.
    loshz authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4489855 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aa86bd5 View commit details
    Browse the repository at this point in the history
  6. get it compiling

    loshz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8ade14e View commit details
    Browse the repository at this point in the history
  7. add runner

    loshz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    69d088a View commit details
    Browse the repository at this point in the history
  8. use supergraph watcher

    loshz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cf81340 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7eeac10 View commit details
    Browse the repository at this point in the history
  10. simplify file path getter

    loshz committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    01c5128 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. implement subgraph watching

    loshz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ecaa218 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1adfc0d View commit details
    Browse the repository at this point in the history
  3. fix loop cpu issue

    loshz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    380d5fa View commit details
    Browse the repository at this point in the history
  4. ROVER-135 Make paths in supergraph.yaml resolve relative to the locat…

    …ion of the file, not the current working directory of Rover (#2119)
    
    As per the title, to support integration with the Language Server we
    need to remove a 'quirk' of Rover whereby if you specify a file in the
    supergraph.yaml with a relative path, that path is resolved relative to
    the location that rover is running in at the time. This doesn't work in
    that context so instead we are changing it to resolve relative to the
    location of the supergraph.yaml file itself.
    
    I've added a unit test for this and run my own tests and it all seems to
    work ok.
    
    In addition I've fixed a test that has been broken for a long time, a
    more detailed write up on this test will follow
    
    Successful smoke test run:
    https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
    jonathanrainer authored and dotdat committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e906402 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Aaron/subgraph watch introspection (#2142)

    <!--
    First, 🌠 thank you 🌠 for taking the time to consider a contribution to
    Apollo!
    
    Here are some important details to follow:
    
    * ⏰ Your time is important
    To save your precious time, if the contribution you are making will
    take more than an hour, please make sure it has been discussed in an
            issue first. This is especially true for feature requests!
    
    * 💡 Features
    Feature requests can be created and discussed within a GitHub Issue.
    Be sure to search for existing feature requests (and related issues!)
    prior to opening a new request. If an existing issue covers the need,
    please upvote that issue by using the 👍 emote, rather than opening a
            new issue.
    
    * 🕷 Bug fixes
    These can be created and discussed in this repository. When fixing a
    bug,
    please _try_ to add a test which verifies the fix. If you cannot, you
    should
    still submit the PR but we may still ask you (and help you!) to create a
    test.
    
    * 📖 Contribution guidelines
    Follow https://github.com/apollographql/rover/blob/HEAD/CONTRIBUTING.md
    when submitting a pull request. Make sure existing tests still pass, and
    add
            tests for all new behavior.
    
    * ✏️ Explain your pull request
    Describe the big picture of your changes here to communicate to what
            your pull request is meant to accomplish. Provide 🔗 links 🔗 to
            associated issues!
    
    We hope you will find this to be a positive experience! Open source
    contribution can be intimidating and we hope to alleviate that pain as
    much
    as possible. Without following these guidelines, you may be missing
    context
    that can help you succeed with your contribution, which is why we
    encourage
    discussion first. Ultimately, there is no guarantee that we will be able
    to
    merge your pull-request, but by following these guidelines we can try to
    avoid disappointment.
    
    -->
    
    ---------
    
    Co-authored-by: Aaron Arinder <aaronarinder@gmail.com>
    loshz and aaronArinder authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    87a02fd View commit details
    Browse the repository at this point in the history
  2. handle kind error case

    loshz committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    948d1d3 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'composition-integration' of github.com:apollographql/ro…

    …ver into composition-integration
    loshz committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0316b8e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9bccc19 View commit details
    Browse the repository at this point in the history
  5. slight code reorder

    loshz committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2732026 View commit details
    Browse the repository at this point in the history