-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: implement supergraph watcher #2133
base: composition-integration
Are you sure you want to change the base?
Commits on Sep 10, 2024
-
ROVER-135 Make paths in supergraph.yaml resolve relative to the locat…
…ion of the file, not the current working directory of Rover (#2119) As per the title, to support integration with the Language Server we need to remove a 'quirk' of Rover whereby if you specify a file in the supergraph.yaml with a relative path, that path is resolved relative to the location that rover is running in at the time. This doesn't work in that context so instead we are changing it to resolve relative to the location of the supergraph.yaml file itself. I've added a unit test for this and run my own tests and it all seems to work ok. In addition I've fixed a test that has been broken for a long time, a more detailed write up on this test will follow Successful smoke test run: https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
Configuration menu - View commit details
-
Copy full SHA for 1ed1a27 - Browse repository at this point
Copy the full SHA 1ed1a27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb8c50 - Browse repository at this point
Copy the full SHA 7eb8c50View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f1671af - Browse repository at this point
Copy the full SHA f1671afView commit details -
moving dev_2 over to composition-integration (#2130)
Co-authored-by: Brian George <brian@apollographql.com>
Configuration menu - View commit details
-
Copy full SHA for bdb8186 - Browse repository at this point
Copy the full SHA bdb8186View commit details -
wip(composition): adding composition events, move types around, TODO'…
…d impl of `SubtaskHandleStream` for `Composition` (#2131) Co-authored-by: Brian George <brian@apollographql.com>
Configuration menu - View commit details
-
Copy full SHA for 7586992 - Browse repository at this point
Copy the full SHA 7586992View commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 34dacc6 - Browse repository at this point
Copy the full SHA 34dacc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ec253c - Browse repository at this point
Copy the full SHA 4ec253cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c755ef - Browse repository at this point
Copy the full SHA 5c755efView commit details -
dev leader deprecation (#2132)
## Description Initial PR the remove leader/follower related code so we can build upon implementing new `rover dev` command while keeping changes atomic.
Configuration menu - View commit details
-
Copy full SHA for 4489855 - Browse repository at this point
Copy the full SHA 4489855View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa86bd5 - Browse repository at this point
Copy the full SHA aa86bd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ade14e - Browse repository at this point
Copy the full SHA 8ade14eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69d088a - Browse repository at this point
Copy the full SHA 69d088aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf81340 - Browse repository at this point
Copy the full SHA cf81340View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eeac10 - Browse repository at this point
Copy the full SHA 7eeac10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01c5128 - Browse repository at this point
Copy the full SHA 01c5128View commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ecaa218 - Browse repository at this point
Copy the full SHA ecaa218View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1adfc0d - Browse repository at this point
Copy the full SHA 1adfc0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 380d5fa - Browse repository at this point
Copy the full SHA 380d5faView commit details -
ROVER-135 Make paths in supergraph.yaml resolve relative to the locat…
…ion of the file, not the current working directory of Rover (#2119) As per the title, to support integration with the Language Server we need to remove a 'quirk' of Rover whereby if you specify a file in the supergraph.yaml with a relative path, that path is resolved relative to the location that rover is running in at the time. This doesn't work in that context so instead we are changing it to resolve relative to the location of the supergraph.yaml file itself. I've added a unit test for this and run my own tests and it all seems to work ok. In addition I've fixed a test that has been broken for a long time, a more detailed write up on this test will follow Successful smoke test run: https://github.com/apollographql/rover/actions/runs/10795662532/job/29943305762
Configuration menu - View commit details
-
Copy full SHA for e906402 - Browse repository at this point
Copy the full SHA e906402View commit details
Commits on Sep 17, 2024
-
Aaron/subgraph watch introspection (#2142)
<!-- First, 🌠 thank you 🌠 for taking the time to consider a contribution to Apollo! Here are some important details to follow: * ⏰ Your time is important To save your precious time, if the contribution you are making will take more than an hour, please make sure it has been discussed in an issue first. This is especially true for feature requests! * 💡 Features Feature requests can be created and discussed within a GitHub Issue. Be sure to search for existing feature requests (and related issues!) prior to opening a new request. If an existing issue covers the need, please upvote that issue by using the 👍 emote, rather than opening a new issue. * 🕷 Bug fixes These can be created and discussed in this repository. When fixing a bug, please _try_ to add a test which verifies the fix. If you cannot, you should still submit the PR but we may still ask you (and help you!) to create a test. * 📖 Contribution guidelines Follow https://github.com/apollographql/rover/blob/HEAD/CONTRIBUTING.md when submitting a pull request. Make sure existing tests still pass, and add tests for all new behavior. * ✏️ Explain your pull request Describe the big picture of your changes here to communicate to what your pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues! We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment. --> --------- Co-authored-by: Aaron Arinder <aaronarinder@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 87a02fd - Browse repository at this point
Copy the full SHA 87a02fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 948d1d3 - Browse repository at this point
Copy the full SHA 948d1d3View commit details -
Merge branch 'composition-integration' of github.com:apollographql/ro…
…ver into composition-integration
Configuration menu - View commit details
-
Copy full SHA for 0316b8e - Browse repository at this point
Copy the full SHA 0316b8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bccc19 - Browse repository at this point
Copy the full SHA 9bccc19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2732026 - Browse repository at this point
Copy the full SHA 2732026View commit details