feat: adds HTTP retries for responses w/statuses 500-599 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
feature 🎉
EverlastingBugstopper
force-pushed
the
avery/backoff-retry
branch
from
bd599ad
to
c9da647
Compare
EverlastingBugstopper
force-pushed
the
avery/backoff-retry
branch
3 times, most recently
from
2db96c1
to
c72fb2d
Compare
|
@BrynCooke / @cecton would y'all mind giving this a once-over? I think I could use some recommendations on my testing strategy/general architecture here. |
BrynCooke
approved these changes
Aug 16, 2021
EverlastingBugstopper
force-pushed
the
avery/backoff-retry
branch
from
bbb7be2
to
3c60772
Compare
|
comments addressed! going to see if this still fails to compile on a few of our targets and will investigate if it does. |
|
Builds are only failing on our optional nightly runners due to a regression in nightly Rust. I'm not worried about merging this because this is causing a widely used library to fail to compile ( |
This was referenced Aug 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #693 - there shouldn't be any visible changes to users, there are no additional messages saying we are retrying, no new error messages saying requests were retried, no new CLI options, this all happens behind the scenes. I've set the max amount of time spent retrying to 10 seconds.