sdl-encoder: fix description encodings #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces `Description` helper to encode top-level, field-level and input-level descriptions. This helps unify some of the description logic we've had across multiple files. This commit also checks whether a description string is a block string character or a string character which then determines whether description needs to be multilined. Fixes #728.
|
@lrlna: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
lrlna
commented
Aug 17, 2021
lrlna
commented
Aug 17, 2021
Comment on lines
+32
to
+36
| if is_block_string_character(description) { | ||
| writeln!(f, "\"\"\"\n{}\n\"\"\"", description)? | ||
| } else { | ||
| writeln!(f, "\"\"\"{}\"\"\"", description)? | ||
| } |
There was a problem hiding this comment.
This can be done even more properly, where line 35 actually creates a StringCharacter that would make description look "like this" instead of """like this""". I am keeping it as is to match what Studio has at the moment. This will be aligned directly in apollo-rs encoder.
EverlastingBugstopper
approved these changes
Aug 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
Descriptionhelper to encode top-level, field-level and input-level descriptions. This helps unify some of the description logic we've had across multiple files.This commit also checks whether a description string is a block string character or a string character which then determines whether description needs to be multilined.
Fixes #728.