Merge pull request #164 from apollographql/bugfix/reconnect

Fix for reconnect after manual close

src/client.ts

@@ -116,17 +116,18 @@ export class SubscriptionClient {
 
   public get status() {
     if (this.client === null) {
-      return 0; //readyState 'CONNECTING'
+      return this.wsImpl.CLOSED;
     }
 
     return this.client.readyState;
   }
 
-  public close() {
+  public close(isForced = true) {
     if (this.client !== null) {
-      this.forceClose = true;
+      this.forceClose = isForced;
       this.sendMessage(undefined, MessageTypes.GQL_CONNECTION_TERMINATE, null);
       this.client.close();
+      this.client = null;
     }
   }
 
@@ -423,7 +424,7 @@ export class SubscriptionClient {
   }
 
   private checkConnection() {
-    this.wasKeepAliveReceived ? this.wasKeepAliveReceived = false : this.close();
+    this.wasKeepAliveReceived ? this.wasKeepAliveReceived = false : this.close(false);
   }
 
   private connect() {

src/test/tests.ts

@@ -1936,6 +1936,47 @@ describe('Message Types', function () {
 });
 
 describe('Client<->Server Flow', () => {
+  it('should reconnect after manually closing the connection and then resubscribing', (done) => {
+    const testServer = createServer(notFoundRequestListener);
+    testServer.listen(SERVER_EXECUTOR_TESTS_PORT);
+
+    SubscriptionServer.create({
+      schema: subscriptionsSchema,
+      execute,
+      subscribe,
+    }, {
+      server: testServer,
+      path: '/',
+    });
+
+    const client = new SubscriptionClient(`ws://localhost:${SERVER_EXECUTOR_TESTS_PORT}/`);
+    let isFirstTime = true;
+
+    client.onConnected(async () => {
+      // Manually close the connection only in the first time, to avoid infinite loop
+      if (isFirstTime) {
+        isFirstTime = false;
+
+        setTimeout(() => {
+          // Disconnect the client
+          client.close();
+
+          // Subscribe to data, without manually reconnect before
+          const opId = client.subscribe({
+            query: `query { testString }`,
+            variables: {},
+          }, (err, res) => {
+            expect(opId).not.to.eq(null);
+            expect(err).to.eq(null);
+            expect(res.testString).to.eq('value');
+            testServer.close();
+            done();
+          });
+        }, 300);
+      }
+    });
+  });
+
   it('should close iteration over AsyncIterator when client unsubscribes', async () => {
     subscriptionAsyncIteratorSpy.reset();
     resolveAsyncIteratorSpy.reset();