Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

It's not possible to install this module from master branch #147

Closed
mistic opened this issue May 26, 2017 · 4 comments · Fixed by #208
Closed

It's not possible to install this module from master branch #147

mistic opened this issue May 26, 2017 · 4 comments · Fixed by #208

Comments

@mistic
Copy link
Contributor

mistic commented May 26, 2017

Hi guys ( @Urigo @DxCx @helfer @dotansimha @NeoPhi ),

I tried to install this package as a dependency in a personal project from the master branch apollographql/subscriptions-transport-ws#master but it completely fails. I've already spotted a lot of things that are blocking this feature. What u think about that?

@helfer
Copy link
Contributor

helfer commented May 26, 2017

Hey @mistic! If there are some reasonable changes that will allow us to install the package directly from github, then I think it's definitely worth it! What are the blockers right now?

@dotansimha
Copy link
Contributor

@mistic
I guess that one of the issues was the fact that graphql was a direct dependency (now it's a dev dependency and a peer dependency).
I saw your fork with some attempts: https://github.com/mistic/subscriptions-transport-ws/commits/test , did you managed to fix this issue?

@mistic
Copy link
Contributor Author

mistic commented Jul 5, 2017

@dotansimha not yet. And u? Were u able to fix this? I'll give some more tries today

@mistic
Copy link
Contributor Author

mistic commented Jul 6, 2017

I've opened a PR solving this problem #208.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants