Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

fix(NA): install library from branch #208

Merged
merged 6 commits into from
Jul 7, 2017

Conversation

mistic
Copy link
Contributor

@mistic mistic commented Jul 6, 2017

@Urigo @dotansimha @DxCx this PR closes #147 and makes possible to install this library from master branch through npm. I think that is a really needed feature for example to test a feature/bug fix without waiting for the oficial release. Please take a quick look reviewing it.

@DxCx
Copy link
Contributor

DxCx commented Jul 6, 2017

hey @mistic did you verify that the published package is still installable?
you are doing rimraf src on prepublishOnly but postinstall has compile so..

@mistic
Copy link
Contributor Author

mistic commented Jul 6, 2017

@DxCx you're right. I've made some changes and not it's working :)

@mistic mistic requested review from Urigo, dotansimha and DxCx July 7, 2017 11:16
@dotansimha dotansimha merged commit 454fe36 into apollographql:master Jul 7, 2017
@dotansimha
Copy link
Contributor

That's awesome!! Thanks @mistic !

@mistic mistic deleted the fix-install-from-branch branch July 7, 2017 13:32
@mistic mistic restored the fix-install-from-branch branch July 7, 2017 13:33
baconz pushed a commit to PhiloInc/subscriptions-transport-ws that referenced this pull request Apr 24, 2018
Update Graphql-js to 0.8.1 (fixes test)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's not possible to install this module from master branch
3 participants