Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

feat(NA): add new connection events. #139

Merged
merged 4 commits into from
May 23, 2017

Conversation

mistic
Copy link
Contributor

@mistic mistic commented May 19, 2017

Guys ( @Urigo @DxCx @helfer @dotansimha @NeoPhi ) this PR enables the new connection events discussed in #136.

No breaking change was introduced, however I coded some deprecation warnings.

@mistic mistic mentioned this pull request May 19, 2017
Copy link
Contributor

@DxCx DxCx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :+1 well done :)

@dotansimha
Copy link
Contributor

@mistic please also update the CHANGELOG :)

@mistic
Copy link
Contributor Author

mistic commented May 22, 2017

@dotansimha done 😄

@Urigo
Copy link
Contributor

Urigo commented May 23, 2017

@mistic looks great! could you just resolve the conflicts?

@mistic
Copy link
Contributor Author

mistic commented May 23, 2017

@Urigo done :)

@Urigo Urigo merged commit 3b091ce into apollographql:master May 23, 2017
@Urigo
Copy link
Contributor

Urigo commented May 23, 2017

thank you again @mistic !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants