This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
fix(NA): Non forced close without connection terminate and also some connection's flow improvements #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DxCx
reviewed
Jul 4, 2017
src/client.ts
Outdated
|
|
||
| if (isForced) { | ||
| if (this.checkConnectionIntervalId) { | ||
| clearInterval(this.checkConnectionIntervalId); |
There was a problem hiding this comment.
Should set this with undefined or null
src/client.ts
Outdated
| @@ -424,15 +456,37 @@ export class SubscriptionClient { | |||
| } | |||
|
|
|||
| private checkConnection() { | |||
| this.wasKeepAliveReceived ? this.wasKeepAliveReceived = false : this.close(false); | |||
| this.wasKeepAliveReceived ? this.wasKeepAliveReceived = false : this.close(false, true); | |||
There was a problem hiding this comment.
Please convert into full if and not shortend
mistic
changed the title
dotansimha
reviewed
Jul 7, 2017
| clearTimeout(this.maxConnectTimeoutId); | ||
| this.maxConnectTimeoutId = null; | ||
| } | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Urigo @dotansimha @DxCx
This PR solves the following issue: usually when a backend receives a
connection_terminatewill invalidate the previous credentials so we should only send connection_terminate in aforceClose.