Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Add missing validation step #241

Merged
merged 2 commits into from
Jul 31, 2017
Merged

Add missing validation step #241

merged 2 commits into from
Jul 31, 2017

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Jul 30, 2017 •
edited
Loading

I've found out that server missed validation step.
Added it at the same API as Apollo-Server is:
https://github.com/apollographql/apollo-server/blob/master/packages/apollo-server-core/src/graphqlOptions.ts#L25

Closes #213

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@mistic mistic mentioned this pull request Jul 31, 2017
Closed
mistic
mistic approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@Urigo Urigo merged commit e16cf37 into apollographql:master Jul 31, 2017
@Urigo
Copy link
Contributor

Urigo commented Jul 31, 2017

thank you so much @DxCx ! good to have you back

@DxCx DxCx deleted the validation-rules branch July 31, 2017 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DxCx @Urigo @mistic