This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
improved keep alive handling #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't send keep alive until the connection is established
baconz
pushed a commit
to PhiloInc/subscriptions-transport-ws
that referenced
this pull request
Apr 24, 2018
chore(package):fix badges in readme after org rename.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating our backend server to the latest version of this package we noticed backwards compatible issues with clients that were still on v1 of the protocol. These two fixes ensure that old clients get the deprecated keep alive message and that those messages are not sent until the client successfully establishes a connection (otherwise a keep alive of the wrong message type maybe sent).
TODO: