Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

add option to pass extra websocket client arguments #561

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

GingerBear
Copy link
Contributor

@GingerBear GingerBear commented May 9, 2019

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change (not sure how to change)

Two of the most used websocket node implementation both support 3rd or more arguments to the constructor. Referring to ws doc and WebSocket-Node doc

This PR try adding an extra property to ClientOptions that can be used to pass extra arguments to the custom ws implementation.

@apollo-cla
Copy link

@GingerBear: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@chriswiggins
Copy link

Ping @GingerBear do you want to sign the contributor agreement please? We need this functionality in our app 👍

@GingerBear
Copy link
Contributor Author

@chriswiggins I think... I already signed

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GingerBear!

@hwillson hwillson merged commit 624662e into apollographql:master Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants