Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Destructure the correct error object #588

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Destructure the correct error object #588

merged 1 commit into from
Aug 12, 2020

Conversation

gregbty
Copy link
Contributor

@gregbty gregbty commented Jun 28, 2019

The incorrect error was being returned instead of the one that was returned from formatError. This also supports apollographql/apollo-server#2942.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@apollo-cla
Copy link

@gregbty: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

The incorrect error was being returned instead of the one that was returned from `formatError`.
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes - great catch @gregbty, thanks!

@hwillson hwillson merged commit e193535 into apollographql:master Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants