This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Send INIT before SUBSCRIPTION_START #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoPhi
reviewed
Mar 2, 2017
| @@ -243,6 +243,9 @@ export class SubscriptionClient { | |||
| this.eventEmitter.emit(isReconnect ? 'reconnect' : 'connect'); | |||
| this.reconnecting = false; | |||
| this.backoff.reset(); | |||
| // Send INIT message, no need to wait for connection to success (reduce roundtrips) | |||
There was a problem hiding this comment.
If I isolate this MR to just moving where the INIT message is fired I'm not seeing any test failures. However the addition of the should send INIT message first test below introduces issues.
NeoPhi
reviewed
Mar 2, 2017
src/test/tests.ts
Outdated
| } | ||
| if (parsedMessage.type === SUBSCRIPTION_START) { | ||
| expect(initReceived).to.be.true | ||
| done() |
There was a problem hiding this comment.
Need to setup the client as a function variable and include a client.unsubscribeAll(); prior to calling done() otherwise the client will stick around and try to reconnect.
|
Thanks for the tip, just calling |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the `SUBSCRIPTION_START` is being sent before the `INIT` message. In our case this results in `subscriptions-transport-ws` rejecting the `init_success` of the server. This only happens in rare cases and I could barely reproduce this. The environment that caused this problem looked like this: - Slow connection - Having 2 subscriptions in one application - Using the `react-apollo` client I'm not sure if the apollo client is responsible for the weird early `subscription_end`, but this is already a starting point.Unfortunately, the test I added breaks 3 other Server related tests. Seems some async/concurrency issue, but I couldn't find out what exactly is causing it.
If it is ok for you, I also just can remove this test, as all other tests then still are green.
This is based on PR #84, so you might first merge PR #84.