Switch timing hints to use fieldLatencies query #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgzuke I'd love to get your help to merge this and do a release tomorrow. |
jgzuke
approved these changes
Sep 9, 2021
| const { schemaTags, fieldStats } = | ||
| await engineClient.loadSchemaTagsAndFieldStats(serviceID); | ||
| const { schemaTags, fieldLatencies } = | ||
| await engineClient.loadSchemaTagsAndFieldLatencies(serviceID); |
There was a problem hiding this comment.
I think we need to update the function being called as well
There was a problem hiding this comment.
picky, picky.
(forgot to save a file, whoops!)
This query is backed by a more efficient data store than fieldStats. (We plan to keep old versions of the plugin working by eventually aliasing fieldStats to fieldLatencies, but fieldLatencies is the more appropriate field to use going forward.)
glasser
force-pushed
the
glasser/field-latencies
branch
from
26bfefe to
7d5bad3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query is backed by a more efficient data store than fieldStats. (We plan
to keep old versions of the plugin working by eventually aliasing fieldStats
to fieldLatencies, but fieldLatencies is the more appropriate field to use going
forward.)
┆Issue is synchronized with this Jira Task by Unito